fix(server): keep stdio SSE proxy alive after disconnect - #1701
fix(server): keep stdio SSE proxy alive after disconnect#1701AkhilTrivediX wants to merge 1 commit into
Conversation
|
Closing: v1 is deprecated. Thank you for this contribution, and apologies for the long wait for a response. v1 will receive security fixes only. We reviewed every open v1 PR for security impact before closing — see the backlog triage in #1819 — and a small number were retained for a final If the underlying problem still exists in v2, we'd genuinely like to know. Please open an issue describing it against v2. Note that we accept external contributions as issues rather than pull requests — maintainers handle design and implementation through a prompt-driven workflow. See Thanks again for taking the time to contribute to the Inspector. |
Summary
Root cause
When an Inspector SSE client disconnected, a later stderr notification from the proxied stdio server could call
SSEServerTransport.send()after the transport had closed. Its rejected promise was unhandled, so Node exited withError: Not connected.The proxy now records the failed notification delivery while keeping the transport lifecycle running. The disconnected client still receives no message, but the Inspector process remains available for subsequent connections.
Closes #1014.
Testing
npm run test-servercd client && npm test -- --runInBandnpm run buildnpx prettier --check package.json server/package.json server/src/index.ts server/test/stdio-sse-close.test.ts